docs: update v3 theme docs to use proper branch in URLs#2169
Closed
joeyfigaro wants to merge 3 commits intotailwindlabs:v3from
Closed
docs: update v3 theme docs to use proper branch in URLs#2169joeyfigaro wants to merge 3 commits intotailwindlabs:v3from
joeyfigaro wants to merge 3 commits intotailwindlabs:v3from
Conversation
issue: HTML Element is missing end tag. solution: Corrected typo where the "/" character was missing in the end-tag.
this should hopefully fix issues in [original PR](tailwindlabs/tailwindcss.com#2168) I didn't see any other v3.* branches, so hopefully `v3.3` is the correct branch to address this (and point to for public documentation.) This fixes an issue in the `version < 4.x` docs where links to the default theme break/result in a 404 (presumably because master contains v4 changes.) --- ### Reproducing 1. Visit [tailwindcss.com/docs](https://tailwindcss.com/docs) 2. Select `v3.4.17` in the top-left version dropdown 3. Click `Get started` 4. Click the `Customization > Theme` link in left-hand nav 5. Search for `the default theme configuration` and click one of the resulting links 6. Observe redirect to [a (no longer existing) blob in Github](https://github.com/tailwindlabs/tailwindcss/blob/main/stubs/config.full.js)
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Author
|
Hey @philipp-spiess – thanks for trying a redeploy. Do you have any insights here? I'm unable to view the deployment details. |
joeyfigaro
changed the title
Contributor
|
Yep sure sorry I want to look into it and make it work but didn't get around to it. Seems like some dependency mismatch that needs to be fixed (awkwardly caused by our own dependencies hahaha) 
|
Author
All good! I'll keep checking back in on things to see where everything's at. Maybe I could look into things as well? |
Contributor
|
Looks like these got fixed in #2206 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this should hopefully fix issues in original PR
I didn't see any other v3.* branches, so hopefully
v3.3is the correct branch to address this (and point to for public documentation.)This fixes an issue in the
version < 4.xdocs where links to the default theme break/result in a 404 (presumably because master contains v4 changes.)Reproducing
v3.4.17in the top-left version dropdownGet startedCustomization > Themelink in left-hand navthe default theme configurationand click one of the resulting links